Skip to content

Conversation

eliottness
Copy link
Contributor

What does this PR do?

increase DD_APPSEC_WAF_TIMEOUT default value 1ms -> 2ms

Motivation

We believe the default timeout exclude too much customers from the security data they deserve and the current value ends up taking 0.3% of the requests of our customer where our goal should be around 1% so we believe to have to option to make it bigger for cases that matters

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2025

Benchmarks

Benchmark execution time: 2025-08-27 14:52:34

Comparing candidate commit b576ef8 in PR branch eliottness/increase-waf-timeout with baseline commit 54e8a39 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness eliottness marked this pull request as ready for review August 27, 2025 15:28
@eliottness eliottness requested a review from a team as a code owner August 27, 2025 15:28
Copy link
Contributor Author

/comment

Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 19, 2025

View all feedbacks in Devflow UI.

2025-09-19 13:13:36 UTC ℹ️ Start processing command /merge


2025-09-19 13:13:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 16m (p90).


2025-09-19 13:25:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 847743a into main Sep 19, 2025
244 checks passed
@dd-mergequeue dd-mergequeue bot deleted the eliottness/increase-waf-timeout branch September 19, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants