fix: Try to fix benchmarking#26
Draft
ltfschoen wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix benchmarking error since a solution was mentioned here, but we already applied those changes to our codebase here and we are already using 'polkadot_v0.9.17', and Cumulus 'polkadot_v0.9.17' already includes the change that they said should fix it in their upstream here https://github.com/paritytech/cumulus/commits/polkadot-v0.9.17, but it still doesn't work
When I run
cargo check -p datahighway-collator --features runtime-benchmarksin this PR, it generates error shown below, although this time it is complaining about pallet-xcm rather than pallet-society