[Bug][dinky-admin] Database postgresql adaptation problem #4300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with the same prefix cause errors in Flink configuration parsing (DataLinkDC#4286) Co-authored-by: zhangyuhang <[email protected]> Co-authored-by: yuhang2.zhang <[email protected]>
…s with the same prefix cause errors in Flink configuration parsing. (DataLinkDC#4298) Co-authored-by: yuhang2.zhang <[email protected]>
github-actions
bot
requested review from
Zzm0809,
aiwenmo,
gaoyan1998 and
zackyoungh
|
删除字段的类型问题 可以参考 #3968 中的 dinky-admin/src/main/java/org/dinky/interceptor/PostgreSQLPrepareInterceptor.java 方式来处理 |
Jam804
force-pushed
the
1.2.2
branch
2 times, most recently
from
91e9123 to
0fa4db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix the issue #4262
#4302
#4276
Fix Description
Issue: This PR addresses #4262, which arises due to the use of MyBatis logical deletion. MyBatis treats the is_deleted field as an int, whereas, in the PostgreSQL database, this field is of type boolean, causing a type incompatibility.
Changes Made
Field Type Modification:
Changed the data type of the is_deleted field in the PostgreSQL database from boolean to int to ensure compatibility with MyBatis.
Updated existing data to convert boolean values to int (e.g., true to 1 and false to 0).
After modifying the type, we also tested the MySQL database and found no issues.