Skip to content

Conversation

@ferenc-csaky
Copy link
Collaborator

No description provided.

@ferenc-csaky ferenc-csaky changed the title Feature/flink 2.1 Update to Flink 2.1 Oct 21, 2025
@ferenc-csaky ferenc-csaky linked an issue Oct 27, 2025 that may be closed by this pull request
@ferenc-csaky ferenc-csaky marked this pull request as ready for review October 27, 2025 16:15
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.35%. Comparing base (8842a0b) to head (0714291).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../datasqrl/calcite/dialect/PostgresConformance.java 0.00% 2 Missing ⚠️
...li/src/main/java/com/datasqrl/cli/DatasqrlRun.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1650      +/-   ##
============================================
+ Coverage     62.25%   62.35%   +0.09%     
- Complexity     2749     2750       +1     
============================================
  Files           483      482       -1     
  Lines         15065    15026      -39     
  Branches       1842     1843       +1     
============================================
- Hits           9379     9369      -10     
+ Misses         4824     4795      -29     
  Partials        862      862              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,4 +1,4 @@
//DEPS org.apache.flink:flink-table-common:1.19.3
//DEPS org.apache.flink:flink-table-common:2.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for us to make this something like a managed dependency so user don't need to update it?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the user might want to run the class independently of SQRL (e.g. for unit testing)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I agree that it is kinda annoying for the user to have to track the version. Is there something we could do to automate this @ferenc-csaky (in a different PR ofc)

@ferenc-csaky ferenc-csaky merged commit ea0816e into main Oct 31, 2025
11 checks passed
@ferenc-csaky ferenc-csaky deleted the feature/flink-2.1 branch October 31, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Flink 2.1

4 participants