-
Notifications
You must be signed in to change notification settings - Fork 18
Update to Flink 2.1 #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Flink 2.1 #1650
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
============================================
+ Coverage 62.25% 62.35% +0.09%
- Complexity 2749 2750 +1
============================================
Files 483 482 -1
Lines 15065 15026 -39
Branches 1842 1843 +1
============================================
- Hits 9379 9369 -10
+ Misses 4824 4795 -29
Partials 862 862 ☔ View full report in Codecov by Sentry. |
| @@ -1,4 +1,4 @@ | |||
| //DEPS org.apache.flink:flink-table-common:1.19.3 | |||
| //DEPS org.apache.flink:flink-table-common:2.1.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for us to make this something like a managed dependency so user don't need to update it?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the user might want to run the class independently of SQRL (e.g. for unit testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I agree that it is kinda annoying for the user to have to track the version. Is there something we could do to automate this @ferenc-csaky (in a different PR ofc)
sqrl-testing/sqrl-testing-integration/src/test/resources/usecases/repository/repo.sqrl
Show resolved
Hide resolved
db2757a to
47844b4
Compare
4f577dc to
556cee6
Compare
No description provided.