refactor(filter): simplify time store model logic and fix next-offset bug#811
Open
dopenguin wants to merge 1 commit into
Open
refactor(filter): simplify time store model logic and fix next-offset bug#811dopenguin wants to merge 1 commit into
dopenguin wants to merge 1 commit into
Conversation
dopenguin
requested review from
czirkelbach,
oeninghe-dataport,
raschju and
warm-coolguy
as code owners
|
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
from
5f17e3d to
7c451b8
Compare
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
3 times, most recently
from
f45b965 to
98b7fdf
Compare
dopenguin
force-pushed
the
refactor/polar-input
branch
from
c976070 to
77acbd9
Compare
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
from
98b7fdf to
77acbd9
Compare
dopenguin
force-pushed
the
refactor/polar-input
branch
from
77acbd9 to
226a455
Compare
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
from
ea80495 to
b45f604
Compare
dopenguin
force-pushed
the
refactor/polar-input
branch
from
226a455 to
c404b37
Compare
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
from
b45f604 to
773af17
Compare
dopenguin
force-pushed
the
refactor/polar-input
branch
from
c404b37 to
c588206
Compare
dopenguin
force-pushed
the
vue3/refactor-filter-time-store
branch
from
773af17 to
3d7b85d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #801, the
timestore offiltercould be simplified.Also fixed a bug where the offset was added twice.
Instructions for local reproduction and review
npm run snowboxNote that the selected values for a custom date range stay selected after one switches to another method. I thought that was a neat byproduct as this may be something a user would rather expect.
Relevant tickets, issues, et cetera
Blocked by #810