Fix PHP8.1 issue passing NULL to sha1() #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdio
added a commit
to mdio/Text-Statistics
that referenced
this pull request
Nov 10, 2023
Credits to smulvih2 from DaveChild#55
mdio
added a commit
to mdio/Text-Statistics
that referenced
this pull request
Nov 10, 2023
Credits to smulvih2 from DaveChild#55
Radcliffe
pushed a commit
to Radcliffe/Text-Statistics
that referenced
this pull request
Dec 18, 2023
pattonwebz
added a commit
to equalizedigital/textstatistics
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to PHP8.1 I am getting the following error when a field is empty:
Deprecated function: sha1(): Passing null to parameter #1 ($string) of type string is deprecated in DaveChild\TextStatistics\Text::cleanText() (line 34 of /var/www/vendor/davechild/textstatistics/src/DaveChild/TextStatistics/Text.php).
This PR checks if the string in question is NULL for proper handling.