Open
Conversation
shymega
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
from
b5f24c1 to
97dc902
Compare
marvin1099
reviewed
Mar 2, 2026
marvin1099
reviewed
Mar 2, 2026
marvin1099
reviewed
Mar 2, 2026
shymega
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
5 times, most recently
from
e721203 to
c797f7b
Compare
shymega
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
from
c797f7b to
6b012d1
Compare
shymega
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
2 times, most recently
from
e721203 to
fd4fdbf
Compare
Collaborator
|
Is this ready for testing? |
Member
Author
|
Yes, it does work under NixOS 25.11 with Hyprland.
…On 30.04.2026 05:08, Marvin1099 wrote:
marvin1099 left a comment (DeckCheatz/wemod-launcher#236)
Is this ready for testing?
--
Reply to this email directly or view it on GitHub:
#236 (comment)
You are receiving this because you were assigned.
Message ID: ***@***.***>
|
marvin1099
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
from
292fbc0 to
fd4fdbf
Compare
To avoid ELF binary conflicts between Flatpak and host environments, virtual environments are now created in separate subdirectories: - wemod_venv/flatpak: For Flatpak sandbox environment - wemod_venv/host: For host system environment This ensures that binaries compiled for one environment don't get executed in the other, preventing "wrong ELF class" errors. Changes: - mk_venv(): Creates venv in appropriate subdirectory based on environment - venv_manager(): Checks for existing venv in correct subdirectory - check_flatpak(): Creates host venv in wemod_venv/host with dependencies - Adds venv detection to prevent infinite rerun loops
Adds support for running wemod-launcher on NixOS hosts, particularly when running from inside a Flatpak sandbox. NixOS requires special handling due to its non-standard filesystem layout and package management. Key features: - is_nixos(): Detects NixOS by checking /etc/NIXOS or /run/current-system/nixos-version - Works from inside Flatpak using flatpak-spawn to check host filesystem - get_python_command(): Wraps Python commands with nix-shell when needed - Provides access to python3, tkinter, and pip packages - Handles both Flatpak and host invocations NixOS venv creation: - Uses nix-shell ONLY during venv creation (not for subsequent invocations) - Creates venv with --copies flag to copy Python binary - Bootstraps pip using ensurepip module - Copies tkinter packages from nix-shell into venv's site-packages - Results in self-contained venv that works without nix-shell wrapper - Automatically installs dependencies from requirements.txt Changes: - mainutils.py: Add is_nixos() and get_python_command() functions - setup.py: Add NixOS-specific venv creation in mk_venv() and check_flatpak() - coreutils.py: Update pip() to use venv's bin/python directly, add NixOS comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
marvin1099
force-pushed
the
shymega/fix-flatpak-nixos-host
branch
from
fd4fdbf to
495fec1
Compare
Collaborator
|
Confirmed working on my end too. |
Member
Author
|
Need to fix the issue with the `host` folder being repeated. Also, this
test only really works on NixOS, so I'm not sure if you run NixOS, but
there's not a lot to test on non-Nix distro.
…On 01.05.2026 01:44, Marvin1099 wrote:
marvin1099 left a comment (DeckCheatz/wemod-launcher#236)
Confirmed working on my end too.
Rebased on the newest version.
Should be good to merge.
Give me some confirmation that your done here, then i will merge.
--
Reply to this email directly or view it on GitHub:
#236 (comment)
You are receiving this because you were assigned.
Message ID: ***@***.***>
|
marvin1099
added
under development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.