[DEV][PROFILER] Case 2: Add for-loop unroll tracking to Profiler #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to track for-loop iteration counts in the Profiler client to help identify loops that can potentially be unrolled. Changes: - Add disable_for_loop_unroll_check parameter to Profiler.__init__ - Implement register_for_loop_callback to track loop line numbers and step counts - Deduplicate loop tracking by line number (same loop executed in different blocks) - Display loop statistics in finalize() method - Add test_for_loop_statistics test to verify tracking functionality
Jokeren
reviewed
Oct 18, 2025
| result = result + 1.0 | ||
|
|
||
| # Second for-loop: 5 iterations | ||
| for j in range(5): |
Member
There was a problem hiding this comment.
How about tl.range and tl.static_range? If already static we don't need to unroll the loop
Collaborator
Author
There was a problem hiding this comment.
Done. Now the loop callback returns range type.
Collaborator
Author
There was a problem hiding this comment.
For some reason the current for-loop callbacks are not managed by ClientManager but by class _CombinedLoopHooks. I will move those code back to ClientManager in the future refactoring.
- Extended for_loop_test_kernel to include tl.range and tl.static_range loops - Updated test_for_loop_statistics to verify different range types (python_range, tl_range, tl_static_range) - Modified test assertions to match new loop_info structure with range_type and length attributes - Added validation for 4 different loop types with their expected iteration counts
Collaborator
Author
|
@Jokeren Please review the latest code. |
Jokeren
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to track for-loop iteration counts in the Profiler client to help identify loops that can potentially be unrolled.
Changes: