Skip to content

Conversation

@leoheck
Copy link
Contributor

@leoheck leoheck commented Sep 24, 2025

Hi @DeepSOIC this PR removes extra colon from some menus stated here, #108 and also fix a typo on the "Placement" that was "Placment" before.

@DeepSOIC
Copy link
Owner

this typo is actually intentional. Naming objects "Placement" used to make expression engine crash, most likely because of ambiguity with object's Placement property.

@leoheck
Copy link
Contributor Author

leoheck commented Sep 24, 2025

Ah, ok. Since you said name, I am guessing the label can have this typo fixed. Am I right? If yes, then I could fix the label them, if you are interested.

What about the other changes removing colon from the menu items? Are they good?

@DeepSOIC
Copy link
Owner

labels are treated as names by the expression engine, aren't they?

I don't remember if there is a story behind the colons. Could be to make it obvious that it's a group command in the customization dialog (where one can customize toolbars and bind keyboard shortcuts). I don't have any strong opinions about them.

@leoheck
Copy link
Contributor Author

leoheck commented Oct 25, 2025

Labels are treated as names by the expression engine, aren't they?

Sorry, forgot this question.
The expression engine works with names, but it also works with labels.

We use names this way Placment01.X and labels this way <<My_Placement>>.X
I would like to use them with labels, but I am not sure what will happen if we have 2 objects with the same label.
I just did not have time to check this yet.

But in this case, I don't see any problem with fixing the label to use "Placement". Do you see it?
The name of the object can also be different, like Placment or even Lattice2_Placement
Lattice2 placement could also have a property to make some distinction with other objects to check it before using it.

@DeepSOIC
Copy link
Owner

i have checked FreeCAD v1.0, and it deals with the ambiguity just fine somehow. If the support for older FreeCAD can be ditched (it is kinda spotty anyway; the actual problem was very long ago so it might be no one is affected anyway), i might just go for it, including names...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants