-
Notifications
You must be signed in to change notification settings - Fork 17
Feature: AI project keyword suggestions #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature: AI project keyword suggestions #1597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me! Good job!
client/modules/datafiles/src/projects/forms/BaseProjectForm.tsx
Outdated
Show resolved
Hide resolved
…l and update BaseProjectForm to import via the alias instead of a relative path
* wip rag as view * add CHROMA_ENDPOINT setting * fix missing packages; fix image tag * import SN settings from designsafe.env * working rag view * add error handling; add debounce to rag requests * fix linting * add test settings * use prev value as placeholder; memoize watched values and set debounce to 1 sec * linting * Task/WC-179: Software publication type (#1633) * implement Software publication type * fixes for testing session issues * task/WC-307: updating search checkboxes to include software type (#1637) * implement Software publication type * adding new software checkbox to right search menu * fixing spacing issue hopefully * adding back missing tag * another spacing fix * yet another spacing fix --------- Co-authored-by: Jake Rosenberg <[email protected]> * adding extra words to publish-amend-version button (#1628) Co-authored-by: Jake Rosenberg <[email protected]> * adding flags for tombstones to disable file listings and entity trees (#1621) Co-authored-by: Jake Rosenberg <[email protected]> --------- Co-authored-by: Jake Rosenberg <[email protected]> Co-authored-by: Sarah Gray <[email protected]>
9a88c5a
to
d1a0361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linting check is failing for designsafe/apps/api/ai_keywords/views.py
…ion workflow (#1656) * add publication metadata to chromadb as part of publication workflow * linting * linting
#1651) * move keyword field below description. add helper text to keyword suggestions * formatting * formatting --------- Co-authored-by: Sal Tijerina <[email protected]>
…https://github.com/DesignSafe-CI/portal into task/WIN-40-keyword-suggestion-client-side-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works locally! Also super clean, thanks! I had some feedback, but feel free to disregard it if it doesn't make sense to address.
); | ||
} | ||
|
||
if (error) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm opening a can of worms here, but is this how we want to handle errors? Or should we let the user know that there's an issue with the model? Or should we log the error for our own debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we encounter errors for this feature, they should be hidden from the user. We log errors on the backend, so good there.
<em style={{ color: 'rgba(0,0,0,.45)' }}>Finding suggestions…</em> | ||
</div> | ||
) : list.length === 0 ? ( | ||
<em style={{ color: 'rgba(0,0,0,.45)' }}>No suggestions yet.</em> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another annoying can of worms that I might be opening up, but are there any CSS classes or styling we would want to use instead of setting it manually in the JSX like you do in this chunk? We haven't talked to Wes or anyone yet, so maybe that will be a to-do for later.
Overview:
PR Status:
Testing Steps:
designsafe.env
secrets locally with the latest from stache, which include secrets for chromadb and Tejas.UI Photos:
TODO:
Along with adding Natural Hazard type at the project level to the RAG, each entities has their own required fields that can be helpful, such as:
Simulation --> Simulation type, and Hyb Sim --> Hyb Sim type. None of the other ones have required fields that might be helpful.