fix: improve type safety in follow.ts by removing any usages (#550)#575
Open
yachikadev wants to merge 3 commits into
Open
fix: improve type safety in follow.ts by removing any usages (#550)#575yachikadev wants to merge 3 commits into
any usages (#550)#575yachikadev wants to merge 3 commits into
Conversation
|
@yachikadev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @yachikadev, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all remaining
anyusages fromfollow.tsand replaces them with proper Fastify and JWT types, reusing the existing type definitions insrc/types/fastify.d.ts.Changes
request.server as anyand(app as any).authenticatecasts —FastifyInstance.authenticateandrequest.serverare already properly typed via the existingfastify.d.tsaugmentation, so no casts are needed.(request as any).user = payloadwithrequest.user = payload, typing the JWT payload usingrequest.jwtVerify<AuthenticatedUser>()(imported from../types/fastify.js) so it matches theAuthenticatedUsertype already declared forrequest.user.(request.user as any).idusages withrequest.user.id.catch (error: any)withcatch (error)and used the existinggetErrorMessageutility, matching the error-handling pattern already used elsewhere in this file.Testing
npx tsc --noEmitpasses with no errors.Closes #550