Skip to content

fix: improve type safety in follow.ts by removing any usages (#550) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yachikadev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: improve type safety in follow.ts by removing any usages (#550) #575

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2d5e5e
fix: remove any usages in follow.ts, reuse Fastify/JWT types (#550)
yachikadev Jun 14, 2026
4f4f74b
fix: type jwtVerify payload with AuthenticatedUser
yachikadev Jun 14, 2026
65abec7
fix: add explicit return type and rename unused catch variable for ES…
yachikadev Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions apps/backend/src/routes/follow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
import { getPlatform, getProfileUrl, getWebViewUrl } from '@devcard/shared';

import { decrypt } from '../utils/encryption.js';
import { getErrorMessage } from '../utils/error.util.js';
import { getPlatform, getProfileUrl, getWebViewUrl } from '@devcard/shared';
import { followLogSchema } from '../validations/follow.validation.js';

export async function followRoutes(app: FastifyInstance) {
import type { AuthenticatedUser } from '../types/fastify.js';
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';

export async function followRoutes(app: FastifyInstance): Promise<void> {
app.addHook('preHandler', async (request, reply) => {
const server = request.server as any;
if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
if (typeof (app as any).authenticate === 'function') { await (app as any).authenticate(request, reply); return }
try { const payload = await request.jwtVerify(); if (payload) (request as any).user = payload; } catch (e) { reply.status(401).send({ error: 'Unauthorized' }) }
});
const server = request.server;
if (typeof server?.authenticate === 'function') { await server.authenticate(request, reply); return }
if (typeof app.authenticate === 'function') { await app.authenticate(request, reply); return }
try { const payload = await request.jwtVerify<AuthenticatedUser>(); if (payload) {request.user = payload;} } catch (_e) { reply.status(401).send({ error: 'Unauthorized' }) }
});

// ─── Follow via API (Layer 1) ───
// Currently supports: GitHub
Expand All @@ -19,7 +22,7 @@ export async function followRoutes(app: FastifyInstance) {
request: FastifyRequest<{ Params: { platform: string; targetUsername: string } }>,
reply: FastifyReply
) => {
const userId = (request.user as any).id;
const userId = request.user.id;
const { platform, targetUsername } = request.params;

// GitHub follow tokens are stored under 'github_follow' to prevent the
Expand Down Expand Up @@ -116,7 +119,7 @@ export async function followRoutes(app: FastifyInstance) {
}>,
reply: FastifyReply
) => {
const userId = (request.user as any).id;
const userId = request.user.id;
const { platform, targetUsername } = request.params;

const parsed = followLogSchema.safeParse(request.body);
Expand All @@ -137,8 +140,8 @@ export async function followRoutes(app: FastifyInstance) {
},
});
return reply.send({ status: 'success', logId: log.id });
} catch (error: any) {
app.log.error('Failed to log follow:', error);
} catch (error) {
app.log.error(`Failed to log follow: ${getErrorMessage(error)}`);
return reply.status(500).send({ error: 'Failed to log follow event' });
}
});
Expand All @@ -148,7 +151,7 @@ export async function followRoutes(app: FastifyInstance) {
request: FastifyRequest<{ Params: { platform: string; targetUsername: string } }>,
reply: FastifyReply
) => {
const userId = (request.user as any).id;
const userId = request.user.id;
const { platform, targetUsername } = request.params;

await app.prisma.followLog.deleteMany({
Expand Down