Skip to content

fix: removed lint check for web modules from github checks #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShantKhatri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: removed lint check for web modules from github checks #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/scripts/commentResults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ module.exports = async ({
backendTypecheck,
mobileLint,
mobileTest,
webCheck,
webBuild,
backendLintOutput,
mobileLintOutput,
Expand Down Expand Up @@ -57,7 +56,6 @@ ${mobileLint === 'failure' ? lintDetails(mobileLintOutput) : ''}

| Check | Result |
|---|---|
| Check | ${status(webCheck)} |
| Build | ${status(webBuild)} |

---
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ jobs:
runs-on: ubuntu-latest

outputs:
check_result: ${{ steps.web_check.outcome }}
build_result: ${{ steps.web_build.outcome }}

steps:
Expand All @@ -105,19 +104,13 @@ jobs:
- name: Install web dependencies
run: npm --prefix apps/web install

- name: Web check
id: web_check
continue-on-error: true
run: npm --prefix apps/web run lint

- name: Web build
id: web_build
continue-on-error: true
run: npm --prefix apps/web run build

- name: Fail job if any check failed
if: >
steps.web_check.outcome == 'failure' ||
steps.web_build.outcome == 'failure'
run: exit 1

Expand Down Expand Up @@ -188,7 +181,6 @@ jobs:
backendLint: '${{ needs.backend-ci.outputs.lint_result }}',
backendTest: '${{ needs.backend-ci.outputs.test_result }}',
backendTypecheck: '${{ needs.backend-ci.outputs.typecheck_result }}',
webCheck: '${{ needs.web-ci.outputs.check_result }}',
webBuild: '${{ needs.web-ci.outputs.build_result }}',
mobileLint: '${{ needs.mobile-ci.outputs.lint_result }}',
mobileTest: '${{ needs.mobile-ci.outputs.test_result }}',
Expand Down