Skip to content

Use a single electron analyser detector#1803

Draft
oliwenmandiamond wants to merge 12 commits intomainfrom
single_electron_analyser_detector
Draft

Use a single electron analyser detector#1803
oliwenmandiamond wants to merge 12 commits intomainfrom
single_electron_analyser_detector

Conversation

@oliwenmandiamond
Copy link
Contributor

Fixes #ISSUE

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Contributor

@fajinyuan fajinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with these changes

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (e0d5a17) to head (44cade9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1803   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         288      288           
  Lines       10937    10940    +3     
=======================================
+ Hits        10843    10846    +3     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oliwenmandiamond
Copy link
Contributor Author

This is currently blocked by bluesky/bluesky#1978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments