Add notebook on how to use the config client inside dodal#1860
Add notebook on how to use the config client inside dodal#1860
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 294 294
Lines 11254 11254
=======================================
Hits 11150 11150
Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks fine except there are no examples of output, e.g. from executing cell with "detector_config.get_column_names()"- is it meant to be so? |
|
wait a sec, how to include it in doc build? I did "tox -e docs" but it didn't seem to appear in buld/html/tutorials, so not included in built docs. |
| "id": "4aa10347", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now we can use the `get_file_contents` method to retrieve a config file's contents. Here you should provide the filepath of the file to read, and your desired return type." |
There was a problem hiding this comment.
Would be good to add what kind of error error message you could get if file doesn't exist or return type doesn't match due to configuration being wrong on daq-config-server or requested the wrong thing on dodal side?
Fixes #ISSUE
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}