Open
Conversation
Contributor
|
Could you please remove the formatting changes? |
Ohisemega
force-pushed
the
Fix_EigerDetector_Status_Fix_ISSUE_38
branch
from
7ce64ff to
4eaa524
Compare
Rename status parameter value from 'name' to 'class' given the former is a reserved string in the parameter tree. Add a number of other relevant status parameters to the status() method to expose them to fastcs. Fixes #38
Contributor
Author
I have fixed it now. |
GDYendell
approved these changes
Feb 19, 2026
Contributor
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
Looks good! I will merge this along with the stream2 branch when that is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the 'name' parameter in Eiger detecteor Receiver Process to 'class' as the former is a reserved keyword. Add more status parameters to the get_status() method of the Eiger Frame Receiver, since they will be exposed to the FASTCS.
Fixes #38