Add h5read test to demo h5read failure#91
Merged
jbeilstenedmands merged 5 commits intomainfrom Mar 30, 2026
Merged
Conversation
This reverts commit edcfc66.
This reverts commit 839f362.
c338553 to
41e7c79
Compare
for more information, see https://pre-commit.ci
Collaborator
Author
|
Ok, it turns out I was holding it wrong. I had copied the pattern from miniapp, but recent h5read changes mean that you need to call I think introducing this test is still helpful to demonstrate correct usage, however we should probably update a few other things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to develop a baseline integrator, I was having issues reading images with h5read, encountering this error:
However I notice that if I revert the recent changes to h5read, the function works fine and can read the data without problem. I guess either the metadata in the file is not quite right, or things aren't quite initialized correctly, but it's not clear from the changeset what the issue precisely is.
This PR has two commits, the first adds a test which fails, the second reverts the h5read commit as a demo that commit it is the cause. I'm not planning to merge this PR as is, but would be good to add the test file once the issue is resolved.
To run the test after building:
ctest -L h5read-tests --output-on-failure