-
Notifications
You must be signed in to change notification settings - Fork 7
Updates to DHQ schema to accommodate <biblStruct> from Zotero #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: encoding_workflow
Are you sure you want to change the base?
Conversation
Made changes to the ODD file to accommodate the use of <biblStruct> in DHQ: --reinstate <biblStruct> and its children --add namesdates module --add necessary attributes
sydb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @who and @level comments should be addressed before merge. Do you want me to do that or do you?
common/schema/DHQauthor-TEI.xml
Outdated
| <moduleRef key="textstructure" | ||
| except="argument byline closer div1 div2 div3 div4 div5 div6 div7 docAuthor docDate docEdition docImprint docTitle imprimatur opener titlePage titlePart"/> | ||
| <moduleRef key="figures"/> | ||
| <moduleRef key="namesdates" include="persName orgName placeName surname forename"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously necessary (given that our <biblStruct>s use <persName> with <surname> and <forename> children). But I suspect you don’t want these elements showing anywhere except inside <biblStruct>. If so, we need to either
- Remove these elements from their common classes (e.g.,
<persName>from model.nameLike.agent) and add them back to content model of places the are actually needed (e.g.,<author>); OR - Add a Schematron constraint that whines if one of these is outside a
<biblStruct>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Does not have to be done on this PR, of course.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @juliaflanders go with #2, just a <constraintSpec> will do as we do not expect this to happen much if at all.
common/schema/DHQauthor-TEI.xml
Outdated
| <elementSpec ident="note" mode="change" module="core"> | ||
| <classes mode="change"> | ||
| <memberOf key="model.common" mode="add"/> | ||
| <memberOf key="model.imprintPart" mode="add"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that in DHQ <note> is not a member of model.global, and thus is not already in the content model of <imprint>, I think this is the right way to do this. But my instinct is that this information would be better served by a <ptr> (or perhaps <idno>) that is a direct child of <monogr>, instead. That allows the URL itself to be on the @target attribute, and thus be checked for syntactic correctness (although to be fair, that does not say much), and allows a @type to classify what the pointer is to. Furthermore it is what TEI-in-Libraries recommends as a best practice.
common/schema/DHQauthor-TEI.xml
Outdated
| <desc>Provides a classification of the bibliographic item</desc> | ||
| <datatype> | ||
| <dataRef key="teidata.enumerated"/> | ||
| </datatype> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume we are planning to add a controlled vocabulary at a later date, yes?
|
Syd, thank you for the swift review! One thing that may not have been clear here is that all of our With that proviso--i.e. as long as the resulting schema will validate the biblStructs in the test file--please do feel free to go ahead and make any modifications to the ODD that you think are best! And thanks again. |
|
Minor mods made (and pushed to this branch). As for the format of the Note |
|
I should have put it more precisely (and also realize this is something to coordinate with @amclark42): in many cases, our
I think @amclark42 's thoughts on which makes most sense are likely more relevant than mine; I feel like that third option on principle seems inelegant but the differences might be very small. I prefer to avoid option 2 because it would add a step for the encoders. |
|
@sydb Echoing @juliaflanders, the approach we're taking in the XSLT is to use Zotero's processing instructions to produce To be honest, I'm right there with you — I'd prefer |
|
(That said, I think I've now spotted a few places where my translation isn't matching up with Zotero. Sigh. Back to it.) |
|
More than happy to take the lead on a Zotero issue! |
|
See zotero/translators#3171, if interested. |
|
Some outstanding issues:
|
Made changes to the ODD file to accommodate the use of
<biblStruct>in DHQ:<biblStruct>and its childrenI have put a test file temporarily at articles/999998/test_with_biblStructs.xml, which can be deleted once we're happy with the schema changes.