-
Notifications
You must be signed in to change notification settings - Fork 98
Mouse Events Implementation #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a decent change. However, I'm I'm going to try to land #179 first as I think it's better to make these architectural changes before adding more events.
I think we'll want to move to a model where blitz-shell
just passes on the mousemove
event, and detection of mouseover
/mouseenter
/mouseout
/mouseleave
happens in blitz-dom
.
Sure, i will wait for #179 to land. And can try to rebase to it. Till that time i will try to poke the codes during my spare time to know abit more about the codebase. Appreciate the direction and review |
Hi @nicoburns , I did an attempt to make mouseover/mouseenter/mouseout/mouseleave happening in blitz-dom but i am not able to make it happen. We might need to handle the events on Document of blitzshell for the event, which i dont have access to on the blitz-dom. Not sure if i am able to explain it properly. Any guidance will be appreciated. |
Is this somehow related to missing an "active" state on buttons? I started a discussion here: DioxusLabs/dioxus#3622 |
Its not, blitz is currently being developed and is not the default renderer for dioxus. |
This reverts commit a02ca44.
Resolved conflicts in: - packages/blitz-dom/src/document.rs - packages/blitz-dom/src/events/mod.rs - packages/blitz-shell/src/window.rs - packages/blitz-traits/src/events.rs - packages/blitz-traits/src/lib.rs - Removed deleted file packages/dioxus-native/src/dioxus_document.rs The merge preserves hover functionality from hover_impl branch while incorporating updates from main branch including: - New event system architecture - Updated module structure - New packages and examples - Updated dependencies and configuration
- Fix duplicate function definition in document.rs - Fix field name from 'changed' to 'changed_nodes' in document.rs - Fix import paths in window.rs to match new module structure - Add missing MouseLeave enum variant in events.rs - Update pattern matching in mini-dxn to handle new mouse events
Uh oh!
There was an error while loading. Please reload this page.