Skip to content

Implement Floats #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

Implement Floats #866

wants to merge 48 commits into from

Conversation

@nicoburns
Copy link
Collaborator

@nicoburns nicoburns commented Sep 26, 2025

Objective

@nicoburns nicoburns mentioned this pull request Sep 26, 2025
Merged
@nicoburns nicoburns force-pushed the floats branch 2 times, most recently from 5f58419 to 628cef4 Compare October 16, 2025 11:56
@nicoburns
Float layout WIP
fc48cf3
@nicoburns
Setup BFC inheritance
a55876f
@nicoburns
Float Tests 1
7b0398d
@nicoburns
WIP
30284d9 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Root BFCs contain floats
296f9b2 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Float positioning logic WIP
788a34f 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Implement the clear property for floated boxes
a480330 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Initial impl of find_content_slot + block ifc child placement
20219af 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Account for top-margin when creating block subcontext
957e8d4
@nicoburns
Account for style size when creating root BFC
6ab339b
@nicoburns
WIP
5894370
@nicoburns
Fixup type s/left/bottom/ (block abspos)
9e7f363
@nicoburns
Fixup fmt
7816007
@nicoburns
Fixup float y_offset
c96c936
@nicoburns
Track content-box insets separately from border-box insets
188f5ae
@nicoburns
Fixup root block_ctx width
3e82233
@nicoburns
Fallback to indefinite bfc width
0857e7a
@nicoburns
Move FloatDirection type to style module
c325f90
@nicoburns
Implement simple intrinsic sizing contributions for floats-in-block
215e96a
@nicoburns
Fix horizontal fit check
ff0b417
@nicoburns
Fix warnings and document functions
2829739 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Track whether a float context contains any floats
65f67a9
@nicoburns
find_content_slot fast path in case of no active floats
2354567
@nicoburns
Fix build with float feature disabled
569166d 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix top-margins being counted twice for independent block children
359ee34
@nicoburns
Fix test build
11e3c9b
@nicoburns
Make some helper method public
f4c8092
@nicoburns
Disable float tests
0e36724
@nicoburns
Make independent Block Formatting Contexts suppress margin collapsing
84a1785
@nicoburns
Apply top margins to IFC block children
ef0acc0
@nicoburns
Format floats tests
ded8d8b
@nicoburns
Fix clippy::derivable_impls Default lints
b33d09d 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix some clippy lints
eb70b3b 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Compute y_margin offset (top-margin accounting for collapsing) for
f7074ae 
IFC children of a block container
@nicoburns
Remove commented code
00d01fb
@nicoburns
Fix doc warnings
4267843
@nicoburns
Start documenting private float internals
e55f34a
@nicoburns
Refactor and document float implementation
149faad 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Allow mut lint
ecc67b1 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Remove lint reason for MSRV reasons
7b1e28a 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Add serde derives to float styles
d695679 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Make is_bfc_root function available with float feature disabled
6166713 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix TaffyTree with floats disabled
251118e 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Add FloatIntrinsicWidthCalculator
e9eac43 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Teach the float and clear properties to the test generator
703e9b9 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Make floated_content_height_contribution public
2d0f702
@nicoburns
Force BFC to be independent if it is a scroll container
90e269e
@nicoburns
Add +1 to clear logic
fff4ea6 
A cleared float should be placed in a segment *after* the last placed
float on the cleared side(s)

Signed-off-by: Nico Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Float Layout

2 participants

@nicoburns