Skip to content

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 6, 2025

Summary

This avoids errors related to Object guilds on guild-dependent channel properties when used with user apps. Stubbing methods isn't ideal, but it's arguably better than throwing AttributeErrors at random.

Closely related to #1236, the future of which is still very much undecided at this point.

(context: since interactions don't receive a (proper) guild object, we generally substitute it for Object if necessary. This works fine:tm: for the most part, but some properties (rightfully) expect an actual Guild object)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@github-project-automation github-project-automation bot moved this from Todo to Needs Merge in disnake Apr 23, 2025
@shiftinv shiftinv enabled auto-merge (squash) August 24, 2025 09:23
@shiftinv shiftinv merged commit 440416b into master Aug 24, 2025
29 checks passed
@shiftinv shiftinv deleted the fix/channel-guild-object branch August 24, 2025 09:26
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in disnake Aug 24, 2025
shiftinv added a commit that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants