Skip to content

fix: deprecate with_expiration from Client.fetch_invite #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: deprecate with_expiration from Client.fetch_invite #1297

wants to merge 6 commits into from

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added breaking change Includes breaking changes to code/packaging t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jun 30, 2025
shiftinv
shiftinv reviewed Jul 7, 2025
View reviewed changes
@Snipy7374 Snipy7374 changed the title feat!: remove with_expiration from Client.fetch_invite fix: deprecate with_expiration from Client.fetch_invite Jul 8, 2025
@Snipy7374 Snipy7374 added t: deprecation Deprecation of existing features and removed breaking change Includes breaking changes to code/packaging labels Jul 8, 2025
@Snipy7374 Snipy7374 requested a review from shiftinv July 8, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv Awaiting requested review from shiftinv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: deprecation Deprecation of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old query parameter from fetch_invite
2 participants
@Snipy7374 @shiftinv