Skip to content

Add sort and reverse-sort helpers#281

Open
mwpastore wants to merge 1 commit into
DockYard:masterfrom
mwpastore:add-sort-helpers
Open

Add sort and reverse-sort helpers#281
mwpastore wants to merge 1 commit into
DockYard:masterfrom
mwpastore:add-sort-helpers

Conversation

@mwpastore

Copy link
Copy Markdown

Here is a first swag at adding (sort) and (reverse-sort) helpers. These simplified versions of the (sort-by) helper allow users to computed-sort arrays of values and not just arrays of objects. They use Ember.compare as the comparator and do not accept any additional arguments.

  • (reverse-sort)? (sort-reverse)? Something else?
  • Should it just be one (sort) helper with a reverse boolean argument?

@mwpastore

mwpastore commented Sep 27, 2017

Copy link
Copy Markdown
Author

Hrrm, I didn't touch (previous) or (next) and yet their tests are failing for some reason(s). I experienced the same issue locally with ember try:one ember-release. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant