fix: add min node engine requirement to support mandatory es6 requirement by mongodb 6 package #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to unblock mongodb node driver upgrade to v6 which has min. version req. of node to be v16. [reference](https://github.com/mongodb/node-mongodb-native/blob/HEAD/etc/notes/CHANGES_6.0.0.md)
Author
|
Apart from this more changes will be required in
|
Author
|
Removed CI tests for v14 and 12 - #2 |
Author
|
@DominusKelvin please go ahead and merge in your PR if you think this is good |
makeitcount
changed the title
Author
|
@DominusKelvin did you get a chance to review it? |
Owner
|
Hey @makeitcount I am taking a look right now and it does look good. I will revert after the current code has been reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to unblock mongodb node driver upgrade to v6 which has min. version req. of node to be v16. reference