Skip to content

fix: Allow FileEditTool to create new files for full content writes #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatMaxMatrix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Allow FileEditTool to create new files for full content writes #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions tools/fileedittool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,27 +32,29 @@ def execute(self, **kwargs) -> str:
new_content = kwargs.get('new_content')

try:
if not os.path.exists(file_path):
raise FileNotFoundError(f"File not found: {file_path}")

with open(file_path, 'r', encoding='utf-8') as file:
original_content = file.read()
lines = original_content.splitlines()

# ← Removed existence check here
if edit_type == "full":
updated_content = new_content
else:
start_line = kwargs.get('start_line')
end_line = kwargs.get('end_line')
search_pattern = kwargs.get('search_pattern')
replacement_text = kwargs.get('replacement_text')
# Only read if file exists and doing partial edits
if os.path.exists(file_path): # ← Moved existence check here
with open(file_path, 'r', encoding='utf-8') as file:
original_content = file.read()
lines = original_content.splitlines()

start_line = kwargs.get('start_line')
end_line = kwargs.get('end_line')
search_pattern = kwargs.get('search_pattern')
replacement_text = kwargs.get('replacement_text')

if start_line is not None and end_line is not None:
updated_content = self._edit_by_lines(lines, start_line, end_line, new_content)
elif search_pattern and replacement_text:
updated_content = self._find_and_replace(original_content, search_pattern, replacement_text)
if start_line is not None and end_line is not None:
updated_content = self._edit_by_lines(lines, start_line, end_line, new_content)
elif search_pattern and replacement_text:
updated_content = self._find_and_replace(original_content, search_pattern, replacement_text)
else:
raise ValueError("Invalid partial edit parameters")
else:
raise ValueError("Invalid partial edit parameters")
raise ValueError("File must exist for partial edits") # ← New error message

with open(file_path, 'w', encoding='utf-8') as file:
file.write(updated_content)
Expand Down