Skip to content

New try to formatting #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikhailPI1 wants to merge 2 commits into
base: fix_get_lecturer_by_tbid
Choose a base branch
from
Open

New try to formatting #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa2f7e
New try to formatting
DrNeumann388 Nov 6, 2025
e3d31a8
Merge branch 'fix_get_lecturer_by_tbid' into fix_get_lecturer_by_tbid
MikhailPI1 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions rating_api/routes/lecturer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,7 @@ async def update_lecturer_rating(

@lecturer.get("/timetable-id/{timetable_id}", response_model=LecturerGet)
async def get_lecturer_by_timetable_id(timetable_id: int) -> LecturerGet:
lecturer: Lecturer = (
Lecturer.query(session=db.session)
.filter(Lecturer.timetable_id == timetable_id)
.one_or_none()
)
lecturer: Lecturer = Lecturer.query(session=db.session).filter(Lecturer.timetable_id == timetable_id).one_or_none()
if lecturer is None:
raise ObjectNotFound(Lecturer, timetable_id)
result = LecturerGet.model_validate(lecturer)
Expand Down
14 changes: 5 additions & 9 deletions tests/test_routes/test_lecturer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,31 +40,27 @@ def test_create_lecturer(client, dbsession, response_status):


@pytest.mark.parametrize(
"lecturer_n, response_status",
'lecturer_n, response_status',
[
(0, status.HTTP_200_OK),
(1, status.HTTP_200_OK),
(2, status.HTTP_200_OK),
(3, status.HTTP_404_NOT_FOUND),
],
)
def test_get_lecturer_by_timetable_id(
client, dbsession, lecturers, lecturer_n, response_status
):
def test_get_lecturer_by_timetable_id(client, dbsession, lecturers, lecturer_n, response_status):
lecturer = (
dbsession.query(Lecturer)
.filter(Lecturer.timetable_id == lecturers[lecturer_n].timetable_id)
.one_or_none()
dbsession.query(Lecturer).filter(Lecturer.timetable_id == lecturers[lecturer_n].timetable_id).one_or_none()
)
timetable_id = -1
if lecturer:
timetable_id = lecturer.timetable_id
get_response = client.get(f"{url}/timetable-id/{timetable_id}")
get_response = client.get(f'{url}/timetable-id/{timetable_id}')
assert get_response.status_code == response_status


@pytest.mark.parametrize(
"lecturer_n,response_status",
'lecturer_n,response_status',
[
(0, status.HTTP_200_OK),
(1, status.HTTP_200_OK),
Expand Down