Conversation
Herklos
force-pushed
the
feature/add-polymarket
branch
16 times, most recently
from
412961e to
ae46090
Compare
Author
|
It's ready |
Herklos
force-pushed
the
feature/add-polymarket
branch
7 times, most recently
from
410229f to
590d33c
Compare
GuillaumeDSM
reviewed
Jan 2, 2026
Member
GuillaumeDSM
left a comment
GuillaumeDSM
left a comment
There was a problem hiding this comment.
there is no need to store the py version?
Herklos
force-pushed
the
feature/add-polymarket
branch
2 times, most recently
from
22805d0 to
4fbd3ae
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
5 times, most recently
from
119543d to
f329cdc
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
2 times, most recently
from
c0abda0 to
5bd0e15
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
from
5bd0e15 to
26672b8
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
4 times, most recently
from
bff543a to
db0bc5e
Compare
Signed-off-by: Herklos <herklos.dev@protonmail.com>
Herklos
force-pushed
the
feature/add-polymarket
branch
5 times, most recently
from
362f200 to
9cfe0e0
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
5 times, most recently
from
f2e904f to
8c418e6
Compare
…resolution rounds price to 0
When a market's defaultTickSize (0.01) rounds a low price like 0.003956 to
0.00, makerAmount becomes 0 causing the API to reject the order with:
"invalid amounts, maker and taker amount must be higher than 0"
In buildAndSignOrder, after rounding the price, check if it became 0. If
so, scan the price string for the first non-zero decimal digit to determine
the minimum precision needed, then re-round with that precision.
Example: 0.003956 with priceDecimals=2 → 0.00 (broken)
neededDecimals=3 → re-round → 0.004 (correct)
Also update market['info']['tick_size'] in fetchOrderBook so future order
calls use the correct rounding config once the order book has been fetched.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Herklos
force-pushed
the
feature/add-polymarket
branch
from
8c418e6 to
6e1d536
Compare
Herklos
force-pushed
the
feature/add-polymarket
branch
from
ffd74f7 to
a50cfbe
Compare
…P-712 struct Implements full Polymarket CLOB V2 cutover (go-live 2026-04-28 ~11:00 UTC): - EIP-712 Order struct: drop taker/nonce/feeRateBps/expiration from signed types; add timestamp(uint256 ms), metadata(bytes32), builder(bytes32) - Domain version '1' → '2' (mainnet only; Amoy testnet keeps '1' for V1 contracts) - V2 mainnet exchange/negRiskExchange contracts + pUSD/usdce/onramp/offramp addresses - expiration kept in POST /order wire body only (excluded from signed struct per V2 spec) - feeSchedule parsing from Gamma market payload (Mar 31 2026 change) - Keyset cursor pagination in fetchMarkets/fetchOrders/fetchTrades (Apr 10 2026) - wrapCollateral(): thin helper to wrap USDC.e → pUSD via CollateralOnramp.wrap() - builderCode bytes32 pass-through + length validation (66 chars, 0x-prefixed) - getSignatureType(): honour caller params.signatureType/signature_type override - Fix extend() order in fetchOrders/fetchTrades so loop cursor wins over params - salt = orderTimestamp (unified from separate milliseconds() calls) - pro/polymarket.ts: declare missing marketUpdates property Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Herklos
force-pushed
the
feature/add-polymarket
branch
from
a50cfbe to
3e97512
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.