Handle empty module full_paths in drmemtrace func_trace#7825
Merged
derekbruening merged 2 commits intomasterfrom Mar 3, 2026
Merged
Handle empty module full_paths in drmemtrace func_trace#7825derekbruening merged 2 commits intomasterfrom
derekbruening merged 2 commits intomasterfrom
Conversation
We've seen crashes in drmemtrace func_trace code which seem to be from null module full_path fields. This has been seen elsewhere, and other DR code checks for null in this field. We add such null checks to func_trace. End-to-end testing is difficult as we do not fully understand when the path is completely absent. There are no unit tests set up for these func_trace functionscode; leaving that as beyond the scope of this simple fix.
abhinav92003
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen crashes in drmemtrace func_trace code which seem to be from null module full_path fields. This has been seen elsewhere, and other DR code checks for null in this field. We add such null checks to func_trace.
End-to-end testing is difficult as we do not fully understand when the path is completely absent. There are no unit tests set up for these func_trace functions; leaving that as beyond the scope of this simple fix.