i#7447: Fix ninja rebuild problem#7834
Merged
derekbruening merged 1 commit intomasterfrom Mar 10, 2026
Merged
Conversation
Fixes a problem with ninja incorrectly rebuilding targets by using an explicit target for the loader script used to set the preferred base and other aspects of our libaries. An explicit custom target with a dependence provides a top level output which works properly with ninja; ninja does not work well with the cmake PRE_LINK we were using. Tested in a fresh config where repeated "ninja" does nothing as it should where before it kept rebuilding libraries. Fixes #7447
edeiana
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a problem with ninja incorrectly rebuilding targets by using an explicit target for the loader script used to set the preferred base and other aspects of our libaries. An explicit custom target with a dependence provides a top level output which works properly with ninja; ninja does not work well with the cmake PRE_LINK we were using.
Tested in a fresh config where repeated "ninja" does nothing as it should where before it kept rebuilding libraries.
Fixes #7447