feat: Add settings example
#35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirdock
reviewed
May 28, 2025
Contributor
Kirdock
left a comment
Kirdock
left a comment
There was a problem hiding this comment.
Some remarks :)
- Is there any specific reason why each
yamlfile starts with a_? - Should we name the
yamlfiles a bit differently in order to make it more clear, what we want to show with thisyamlfile? - Would be nice if we could also add an example for this
insertAfter:
insertAfter:
configId: other-app
configType: application-web
property: id
type: reference- Not sure if I just oversee it, but Is there any difference between
_my-app.yamland_other-app.yaml?
| ## Requirements | ||
|
|
||
| - Monaco `v2.22.0+` | ||
| - Dynatrace Platform environment |
Contributor
There was a problem hiding this comment.
This is actually not a requirement, right? Classic also works.
Also, in here, OAuth and token are mentioned, but when looking at it, it looks like both are required, but it's only one.
|
|
||
| ## Requirements | ||
|
|
||
| - Monaco `v2.22.0+` |
|
|
||
| ## Requirements | ||
|
|
||
| - Monaco `v2.22.0+` |
Contributor
There was a problem hiding this comment.
To be aligned, we should end with a . for every bullet point.
Contributor
|
@Laubi : We need to rework this example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two basic examples for settings 2.0 with 1) a really basic example and 2) a more complex example utilizing first & last.