Add srgslodad example #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-b
reviewed
Jul 21, 2025
johannes-b
reviewed
Jul 21, 2025
service_monitoring_validation/service_monitoring_sample/config.yaml
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-dashboard.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-dashboard.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-dashboard.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-dashboard.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-guardian.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-slo-availability.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-slo-performance.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-srg-val-standard.json
Outdated
Show resolved
Hide resolved
service_monitoring_validation/service_monitoring_sample/booking-service-srg-val-standard.json
Outdated
Show resolved
Hide resolved
johannes-b
reviewed
Jul 22, 2025
stefaneberl
requested changes
Jul 22, 2025
stefaneberl
left a comment
stefaneberl
left a comment
There was a problem hiding this comment.
README.md is IMHO something that needs to be fixed. My other comments are "nice to haves".
service_monitoring_validation/service_monitoring_sample/myservice-slo-alert-notification.json
Show resolved
Hide resolved
stefaneberl
approved these changes
Jul 22, 2025
|
@g3kl JFYI I've added @j-poecher as well for the SRG part. |
johannes-b
reviewed
Jul 24, 2025
| "description": "Measures the proportion of successful service requests over time.", | ||
| "name": "{{ .name }}", | ||
| "sliReference": { | ||
| "templateId": "e2J1aWx0aW46aW50ZXJuYWwuc2VydmljZS5sZXZlbC5vYmplY3RpdmUudGVtcGxhdGVzLCBpZDogYTU2NWMzNGEtYzVhNS00MTE1LTkzMTEtMDcxYjRjYjU5ZGQ3fQ==", |
Contributor
There was a problem hiding this comment.
@g3kl should we remove the reference to a templateId and rather use a custom SQL?
Contributor
Author
There was a problem hiding this comment.
we certainly can. Maybe this makes it easier for users to understand how the SLI is calculated.
I'll update them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new example of a service health and validation dashboard, including a combination of the following resources