Validation of file entries#74
Merged
dockmd merged 15 commits intointegrationfrom Nov 19, 2024
Merged
Conversation
- restored `Optional` import; and - made `FileEntry.path` files `Optional` as per original PR.
carlwilson
added a commit
to DILCISBoard/eark-json-schema
that referenced
this pull request
Oct 2, 2024
- reflects changes to `eark-validator` in E-ARK-Software/eark-validator#74.
carlwilson
reviewed
Oct 2, 2024
Member
carlwilson
left a comment
carlwilson
left a comment
There was a problem hiding this comment.
While I approve of these changes I want to see what effects they have on the JSON schema compatibility with commons-ip. It's the new InvalidFileEntry type I'm wondering about, these are reported differently in commons-ip. It might not matter but will test before approving.
There is a PR for the generated schema here: DILCISBoard/eark-json-schema#3
carlwilson
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation of file entries attributes:
As before, the correct files from mets.xml are included in the end result in package/mets/file_entries. However, files with detected errors are placed in package/mets/invalid_file_entries together with the error ids. For now, this is just a requirement ids, but perhaps in future this could more descriptive.