A few fixes (#807 #820) and changes (matching a few in-game numbers)#824
A few fixes (#807 #820) and changes (matching a few in-game numbers)#824lyravega wants to merge 4 commits intoEDCD:developfrom
Conversation
…calculations, matching some in-game numbers
|
Thanks for this, I haven't had a chance to properly look at this yet, despite trying (Busy IRL). I will take a look as soon as I can. There was previously an issue where the fuel tank mass was/wasn't being taken into account in different circumstances and it was screwing with the mass calculations and Distance calculations and I fixed that previously, so will need to take a close look at what this is actually doing. |
|
Eh, I just noticed that I messed up spacing (especially in Calculations.js). Fixed. |
|
Apologies for not using this PR yet, would you consider looking at the https://github.com/Brighter-Applications/coriolis and https://github.com/Brighter-Applications/coriolis-data repos and see whether you can submit your PR there against the alpha branch instead? This makes it much easier for me to implement users PR's in the live versions of the site. The site has just undergone a massive upgrade from React 15 to React 19 and lots of the codebase has changed from what was here in the develop branch. |
Fixes #807, Fixes #820
Fixes:
• Fuel tanks were being included as extra mass in 'unladenMass', causing the calculations to use fuel mass value twice. Separated fuel from 'unladenMass' as 'outfittedMass' and utilized it in place to avoid the calculation issues.
Changes:
• 'reserveFuelCapacity' isn't included in FSD range calculations except the Unladen ones. This allows the jump range values on the website to match the in-game ones.
• Similarly, Unladen/Laden Mass displays include 'reserveFuelCapacity' to match the in-game values now. Unsure if this actually is used in calculations, but since the above fix allowed some values to match, decided to match this one as well.
In-game values and fix result for this build:

Profile comparison for live (orange) & fix (blue) for this fuel tank loaded build:
