Skip to content

Add GHA for linting with ruff#48

Merged
fapdash merged 7 commits into
EMPRI-DEVOPS:masterfrom
fapdash:add-ruff-gha
Mar 8, 2026
Merged

Add GHA for linting with ruff#48
fapdash merged 7 commits into
EMPRI-DEVOPS:masterfrom
fapdash:add-ruff-gha

Conversation

@fapdash
Copy link
Copy Markdown
Collaborator

@fapdash fapdash commented Mar 8, 2026

TODOs

  • fix linting errors
  • use fixed version for ruff (need to specify in GHA and mise.toml)
    • I think it's fine to use latest for now

@fapdash fapdash mentioned this pull request Mar 8, 2026
1 task
fapdash added 5 commits March 8, 2026 21:11
Imports are placed at the bottom of __init__.py to deal with circular
dependencies.
The imported class imports something defined in __init__.py, so we get
into a recursive search for those imports if the statement where
placed on top. It's therefore the right solution to ignore this
linting error.

https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/
@fapdash fapdash merged commit 63a9cfc into EMPRI-DEVOPS:master Mar 8, 2026
7 checks passed
@fapdash fapdash deleted the add-ruff-gha branch March 8, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant