Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Dec 2, 2025

validating cf standard names requires fetching a standard name table from github, but when working offline that's not possible. This PR adds a fallback (no name validation) when a URL error is raised when fetching the cf standard name table, which makes it possible to work on the package offline.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/eopf_geozarr/data_api/geozarr/common.py 73.33% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@emmanuelmathot
Copy link
Contributor

@d-v-b This ws included in #75 as well right? We can close?

@d-v-b
Copy link
Contributor Author

d-v-b commented Dec 5, 2025

@d-v-b This ws included in #75 as well right? We can close?

yes this went in already. closing

@d-v-b d-v-b closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants