support etl as an ESP-IDF component #1206
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to make etl integration into the ESP-IDF ecosystem painless. Without this patch, it took me a while to figure out a way to integrate this library into the build, here is what's needed:
main
) CMakeLists.txt:This change aims to support etl with ESP-IDF's component system. The return from the cmake file processing early is necessary because ESP-IDF runs cmake in script mode, where all paths are flattened, and
${CMAKE_CURRENT_SOURCE_DIR}/cmake/helpers.cmake
is resolved incorrectly, failing the build. With this modification, etl can be used with the established component syntax: