fix: #186 token as request param is deprecated #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consul now warns aggressively when token is provided as a request param and the X-Consul-Token is required. Also as already mentioned in Ecwid#186 token request param will be removed in Consul v1.17. By reading the code and related PRs I've seen that in the so called "new http architecture" this is addressed although not all clients fully utilize the new Request class. This PR uses the Request class for both Catalog and KV clients. Should address both Ecwid#186 and Ecwid#237.
|
There is also #132 and other token related issues which may need some more effort but it's feasible to get them fixed. If the maintainers (@vgv ?) are interested I could make another PR and try to address as much clients and API operations as possible. |
ipop94
approved these changes
Aug 10, 2023
enix223
approved these changes
Jan 21, 2024
|
Should we declare this project abandoned? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul now warns aggressively when token is provided as a request param and the X-Consul-Token is required. Also as already mentioned in #186 token request param will be removed in Consul v1.17.
By reading the code and related PRs I've seen that in the so called "new http architecture" this is addressed although not all clients fully utilize the new Request class.
This PR uses the Request class for both Catalog and KV clients.
Should address both #186 and #237.