Add thread sleep after serial port opening #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #288
Summary
By adding a
sleepright after the serial port opening in theMotorDrive::Setupmethod, it eliminates theresponse timed outerrors when talking to the MCU (in the Arduino board). This way, once the port is opened, the MCU has time to boot up and stabilize after the MCU reset caused by opening the serial port the first time. Thesleepis also added before configuring the DTR setting for the port, otherwise it can trigger a 2nd reset while the MCU is still booting up from the first reset, causing timing issues later.Then, possibly due to these timing issues, having the
sleepapplied only after calling theMotorDrive::Setupmethod as it is now in the Motor Demo App didn't properly work as well. Therefore, now thatsleepis added right after the serial port is opened inMotorDrive::Setup, we can also remove thesleepfrom the Motor Demo App as it doesn't seem to be required anymore (no timeout errors were observed).Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.