validate batch size before collecting #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciaquirke
force-pushed
the
validate-batch
branch
from
91a5e51 to
17f8865
Compare
luciaquirke
commented
Nov 13, 2025
|
|
||
| def validate_batch_size( | ||
| model: PreTrainedModel, | ||
| token_batch_size: int | None, |
Collaborator
Author
There was a problem hiding this comment.
swap arg order
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of natural variance in batches it's possible for some time to pass before an OOM error. This is intended to make the error happen immediately. I'm not sure whether this belongs in collect_gradients or in the build/query scripts but it can be more concise if it happens here.
Closes #56