Get coupling grid information from Elmer internals instead of file #772
+205
−481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce bool is_root_rank
* Implement functionality from elmer_grid.{h,c} into Fortran if possible
* Do coordinate conversion in project_to_lonlat.{c,h}
raback
approved these changes
Feb 11, 2026
Contributor
raback
left a comment
raback
left a comment
There was a problem hiding this comment.
Looks good to me and only affects the coupling!
Personally I like to inline the messages more so:
WRITE(Message,*) 'Running with ',ParEnv % PEs ,' partitions'
CALL INFO(SolverName,Message,Level=3)
becomes
CALL Info(SolverName,'Running with '//I2S(ParEnv % PEs)//' partitions',Level=3)
which also has a spacing more appealing to the eye.
But this is merely a tip. I2S is used a lot in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #723 (only SSA)
This is a feature branch contributing to
yac-coupling.@ClemensSchannwell tested this code on my fork BenjaminRodenberg#1.