-
Notifications
You must be signed in to change notification settings - Fork 5
[DO NOT MERGE] Refactor/aiter integration #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor-fp8-linear
Are you sure you want to change the base?
Conversation
…ctor Signed-off-by: vllmellm <[email protected]>
…or/aiter_integration
…or/aiter_integration Signed-off-by: vllmellm <[email protected]>
Signed-off-by: vllmellm <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
|
||
| if self.strategy == QuantizationStrategy.BLOCK: | ||
| maybe_post_process_fp8_weight_block(layer) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if fp8_linear is initialised.
| N = w_q.shape[1] | ||
| K = w_q.shape[0] | ||
|
|
||
| if N % 16 == 0 and K % 16 == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add https://github.com/ROCm/vllm/blob/c88d6d2ec7299605bb2ed8a4aee9260d90ef0631/vllm/model_executor/layers/quantization/compressed_tensors/schemes/compressed_tensors_w8a8_fp8.py#L153 to the rocm_aiter_ops and use that to replace this if conditions.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.