Hotfix/mi rna filter venv #489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running some tests prior to approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details
Is this a fix/ update/ new feature?
This is a fix to allow miRNA filtering with random forest classifier in newer python environments
Include a short description
Created new script to load model and scaler from json rather than complex pickle files. Updated config of the Short Non Coding pipeline to call this script.
Include links to JIRA tickets
Testing
Have you tested it?
Tested as standalone versus previous implementaiton with 100% recapitulation of output. Tested by substituting old pyenv based command in active pipeline with successful outcome.
Have not reinitialised a pipeline to test end-to-end
Assign to the weekly GitHub reviewer
If you are a member of Ensembl, please check the Genebuild weekly Rotas and assign this week's GitHub reviewer to the PR