Add HTTP Request timeout and error handling #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azangru
reviewed
Sep 16, 2025
| <span class="search-param-value">{{ response.stable_id }}</span> | ||
| </div> | ||
| {% if response.code == 404 and response.message %} | ||
| {% if (response.code == 404 or response.code == 500) and response.message %} |
There was a problem hiding this comment.
The id_content.html isn't really well-suited for showing the 500 error. For that matter, it doesn't really fit the 404 error either. The Venn diagram doesn't make sense here. There isn't a 'redirect' happening.
Also, I realise that the 404 page says:
You will be redirected to the new Ensembl website, where you will find the latest genomic information
which isn't correct (the 404 page isn't redirecting user anywhere).
I don't have any concrete solutions for this; just pointing this out. I wouldn't say that this is a blocker.
veidenberg
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
NCBI api requests were failing because of connection timeout and application was going down because errors were not handled. This PR adds timeouts and returns appropriate response in case of http errors