Facilitate config of contributing gene trees #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In conjunction with eg-web-metazoa PR 48, this pull request would facilitate handling of gene tree configuration.
This PR would:
EnsEMBL::Web::Object::Gene::_resolve_clusterset_ids
, which resolves the appropriate consensus and alternativeclusterset_id
values;EnsEMBL::Web::Object::Gene::get_GeneTree
to prioritise an explicitclusterset_id
parameter over a consensus clusterset (e.g."pig_breeds"
) where thatclusterset_id
represents an alternative clusterset appropriate to the given gene-tree view, facilitating display of contributing clustersets of a strain gene tree (e.g."pig_breeds_raxml_parsimony"
);EnsEMBL::Web::Object::Gene::get_GeneTree
to use the consensus clusterset if a given gene or tree is not relevant to the current gene-tree view;EnsEMBL::Draw::GlyphSet::genetree::features
method to use theref_root_id
of a gene tree in order to fetch the reference/consensus gene tree (instead of explicitly requesting the"default"
gene tree);EnsEMBL::Web::ViewConfig::Gene::ComparaTree::_replace_default_clusterset_id_option
, which can be used to replace the"default"
clusterset_id
option with an explicit defaultclusterset_id
(e.g. strain consensus clusterset"murinae"
);EnsEMBL::Web::ViewConfig::Gene::ComparaTree::init_form_non_cacheable
to facilitate configuration of the contributing clustersets of a strain gene tree, and to replace the defaultclusterset_id
with the relevant strain consensus clusterset;align_type
andclusterset_id
are passed as parameters for data export, while removing the (unused) Newick/NHX/Textclusterset_id
dropdown from the gene-tree export config modal window;Views affected
This PR would affect strain and default gene-tree views, as well as the gene-tree config modal window.
See related ticket ENSCOMPARASW-8520 for an example test case.
Possible complications
None expected, though the changes to handling of
$clusterset_id
in methodEnsEMBL::Web::Object::Gene::get_GeneTree
merit consideration.Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)