Skip to content

Facilitate config of contributing gene trees #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Jul 6, 2025

Description

This draft pull request would:

  • update EnsEMBL::Web::Object::Gene::get_GeneTree to prioritise an explicit clusterset_id parameter over a strain consensus clusterset (e.g. "pig_breeds"), facilitating display of contributing clustersets of a strain gene tree (e.g. "pig_breeds_raxml_parsimony");
  • change EnsEMBL::Web::Object::Gene::get_GeneTree to fall back on the consensus clusterset if a given gene or tree is not relevant to the current gene-tree view;
  • adjust the EnsEMBL::Draw::GlyphSet::genetree::features method to use the ref_root_id of a gene tree in order to fetch the reference/consensus gene tree (instead of explicitly requesting the "default" gene tree);
  • add method EnsEMBL::Web::ViewConfig::Gene::ComparaTree::_replace_default_clusterset_id_option, which can be used to replace the "default" clusterset_id option with an explicit default clusterset_id (e.g. strain consensus clusterset "murinae");
  • update method EnsEMBL::Web::ViewConfig::Gene::ComparaTree::init_form_non_cacheable to facilitate configuration of the contributing clustersets of a strain gene tree, and to replace the default clusterset_id with the relevant strain consensus clusterset;
  • ensure align_type and clusterset_id are passed as parameters for data export, while removing the (unused) Newick/NHX/Text clusterset_id dropdown from the gene-tree export config modal window.

Views affected

This draft PR would affect strain and default gene-tree views, as well as the gene-tree config modal window.

See related ticket ENSCOMPARASW-8520 for an example test case.

Possible complications

None expected.

Merge conflicts

None detected.

Related JIRA Issues (EBI developers only)

  • ENSCOMPARASW-8520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant