Cleanup: naming, nesting, error handling, load_lib#38
Merged
Conversation
… load_lib - Rename convert_* functions in academic.lua to bare names matching convention in blocks.lua, reader_blocks.lua, reader_academic.lua - Merge two-pass subfigure scan in figure() into single pass and extract caption logic into local extract_figcaption() helper - Add io.stderr:write() warnings in academic.lua for unexpected nil/empty classes and unmatched academic types - Unify load_lib() in codex.lua and cdx-reader.lua to use same path resolution order (script_dir first) and dofile()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert_*functions inlib/academic.luato bare names (theorem(),proof(), etc.) matching the convention inblocks.lua,reader_blocks.lua, andreader_academic.lua.convert_div()kept as top-level dispatcher.figure(): Merge two-pass subfigure scan into single pass; extract caption logic into localextract_figcaption()helper.io.stderr:write()warnings inacademic.luafor unexpected nil/empty classes inclassify_div()and unmatched academic types inconvert_div().load_lib(): Bothcodex.luaandcdx-reader.luanow use identical path resolution (script_dir first, thenlib/, thencdx-pandoc/lib/) anddofile().Test plan
make clean && make test— all 270 unit tests passmake test-reader— all 27 round-trip tests passmake test-golden— all golden baselines match exactly