Skip to content

refactor: temporarily disable SwipeControl due to memory leak#1119

Merged
ValeraFinebits merged 3 commits intoEppie-io:mainfrom
ValeraFinebits:refactor/temporarily-disable-SwipeControl-due-to-memory-leak
Mar 16, 2026
Merged

refactor: temporarily disable SwipeControl due to memory leak#1119
ValeraFinebits merged 3 commits intoEppie-io:mainfrom
ValeraFinebits:refactor/temporarily-disable-SwipeControl-due-to-memory-leak

Conversation

@ValeraFinebits
Copy link
Contributor

Issue

N/A

Description

Temporarily disable SwipeControl due to memory leak.

Other Information

Pull Request Checklist

Please check if your pull request fulfills the following requirements:

Note

Types of pull requests
  • feat - adding new features
  • fix - bug fixes
  • test - adding or correcting tests
  • perf - changes that improve performance
  • refactor - simple rewriting or restructuring of code without adding new features or fixing bugs
  • style - changes in code styles and no changes in logic
  • build - changes related to the build of the project and dependencies
  • ci - changes related to continuous integration
  • docs - changes in documentation or just comments in source code
  • chore - something that doesn't fit the other possible types
Pull request labels
  • type/breaking-change - pull requests with changes that are not backward compatible
  • type/build - pull requests that change the project's build or dependencies
  • type/chore - pull requests without making changes to the code, project build, formatting, documentation, etc
  • type/ci - pull requests whose changes are related to continuous integration
  • type/documentation - pull requests that only change documentation
  • type/feature - pull requests that add new features
  • type/fix - pull requests that fix a bug
  • type/localization - pull requests that change translation
  • type/performance - pull requests that improve performance
  • type/refactor - pull requests that refactor a section of code
  • type/style - pull requests that change code styles
  • type/test - pull requests that add or correct tests
  • ignore-for-release - for pull requests that do not need to be appeared in release notes

A pull request appears in the release notes if it has one of the labels: type/breaking-change, type/feature, type/fix, type/localization, type/performance

Affected platforms labels
  • platform/all - pull requests that are related to the all platforms
  • platform/android - pull requests that are related to the Android platform
  • platform/desktop - pull requests that are related to the desktop
  • platform/ios - pull requests that are related to the iOS platform
  • platform/macos - pull requests that are related to the macOS platform
  • platform/other - pull requests that are related to an unknown platform
  • platform/uwp - pull requests that are related to the Universal Windows Platform
  • platform/wasm - pull requests that are related to the WebAssembly platform
  • platform/winui - pull requests that are related to the WinUI platform

@ValeraFinebits ValeraFinebits added platform/all Categorizes an issue or PR as relevant to the all platforms type/refactor Pull requests that refactor a section of code labels Mar 12, 2026
@ValeraFinebits ValeraFinebits marked this pull request as ready for review March 12, 2026 21:03
@ValeraFinebits ValeraFinebits requested a review from al-kau as a code owner March 12, 2026 21:03
Copilot AI review requested due to automatic review settings March 12, 2026 21:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily disables swipe gestures on message list items by removing SwipeControl from MessageItemView to mitigate a reported memory leak (TVM-344).

Changes:

  • Commented out the SwipeControl wrapper (and its swipe actions) around MessageItemView content.
  • Kept alternate actions available via context flyout / command bar.
  • Removed now-redundant “leak” comment notes from the message list pages.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/Eppie.App/Eppie.App.Shared/Views/MessageItemView.xaml Disables SwipeControl by commenting it out and keeping the item layout/actions accessible via other UI.
src/Eppie.App/Eppie.App.Shared/Views/FolderMessagesPage.xaml Removes redundant leak comment from the item template.
src/Eppie.App/Eppie.App.Shared/Views/ContactMessagesPage.xaml Removes redundant leak comment from the item template.
src/Eppie.App/Eppie.App.Shared/Views/AllMessagesPage.xaml Removes redundant leak comment from the item template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ValeraFinebits and others added 2 commits March 12, 2026 23:08
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ValeraFinebits ValeraFinebits merged commit 1595200 into Eppie-io:main Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform/all Categorizes an issue or PR as relevant to the all platforms type/refactor Pull requests that refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants