[ts] Replace Array constructors with dynamic initialization for packed number arrays #2955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, you use
new Array(size)to make number arrays. But JS fills the array with empty space and V8 will treat them asHOLEY_SMI_ELEMENTSandHOLEY_DOUBLE_ELEMENTSinstead ofPACKED_SMI_ELEMENTSandPACKED_DOUBLE_ELEMENTS.I grepped through codebase and fixed this in some places, but I don’t think it will result in any noticeable speed-up. I just "scratched the itch"
Feel free to reject, if you don't care :P