Skip to content

Agegroup when arcade#25

Open
asafevenpaz wants to merge 5 commits into
Esri:masterfrom
asafevenpaz:agegroup_when_Arcade
Open

Agegroup when arcade#25
asafevenpaz wants to merge 5 commits into
Esri:masterfrom
asafevenpaz:agegroup_when_Arcade

Conversation

@asafevenpaz

Copy link
Copy Markdown

I have added explanations on how to use the Arcade expression "When" for cases when the data includes an "Age" field but the user wants to group the data into age groups

@ekenes

ekenes commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Sorry @asafevenpaz. I didn't see this one. Is this ready for review?

@asafevenpaz

Copy link
Copy Markdown
Author

Sorry @asafevenpaz. I didn't see this one. Is this ready for review?

Yes. Please review and test

@ekenes ekenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asafevenpaz can you add a link to the https://github.com/Esri/arcade-expressions/blob/master/any/README.md that would direct to this page? That will help make this page more discoverable.

Comment thread any/when_agegroup.md
@@ -0,0 +1,17 @@
# when_agegroup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this text for the link is fine, but can you format this so it's more readable? Maybe something like "Date to age group" or something that describes the function to be used.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this doesn't deal with Date fields. It's still numbers...so it could be even more generic, like "Number to category"

Comment thread any/when_agegroup.md Outdated
Comment thread any/when_agegroup.md Outdated
Comment thread any/when_agegroup.md Outdated
asafevenpaz and others added 3 commits February 24, 2020 12:42
Co-Authored-By: Kristian Ekenes <kekenes@esri.com>
Co-Authored-By: Kristian Ekenes <kekenes@esri.com>
Co-Authored-By: Kristian Ekenes <kekenes@esri.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants