[Update] Show line of sight analysis in map to use callout#773
[Update] Show line of sight analysis in map to use callout#773
Show line of sight analysis in map to use callout#773Conversation
CalebRas
requested review from
a team,
chriswebb09,
mhdostal,
philium and
zkline101
and removed request for
a team,
chriswebb09 and
zkline101
|
Removed Chris and Zach since they are both out. |
| } else { | ||
| 0.0 | ||
| } | ||
| let formattedVisibleLength = visibleLength.formatted(.number.rounded(increment: 1)) |
There was a problem hiding this comment.
Not related to the changes in this PR, but something I noticed: an improvement here would be to format a measurement, which would include the unit in a locale-specific way, modeling best practices.
There was a problem hiding this comment.
I originally thought the same, but using the default measurement format style doesn't seem specific enough. I can override that measurement(width: .abbreviated, usage: .asProvided), but then it doesn't have locale specific units as you suggested. Would you still recommend going with locale units?
| Current | Default Measurement Format Style |
|---|---|
 |
 |
There was a problem hiding this comment.
The measurement value itself can be locale-specific as well (e.g. group separator), so yes, I would still suggest using a measurement and formatting that. Again, that is modeling best practices for our users, who may very well be localizing their app.
Also, you can still format the number how you want by passing a number format style to the numberFormatStyle parameter.
Co-authored-by: Philip Ridgeway <philip.ridgeway@gmail.com>
2 participants
Description
This PR updates
Show line of sight analysis in mapto use a callout to show line of sight visibility info instead of a popover, matching updates made to the design.URL to README: Show line of sight analysis in map
Linked Issue(s)
swift/issues/8058common-samples/pull/4052How To Test
Screenshots