refactor(semantic-shadow-tokens): update inconsistent token styles#12020
Closed
refactor(semantic-shadow-tokens): update inconsistent token styles#12020
Conversation
…ow.md`'s values for consistency
github-actions
bot
added
the
refactor
matgalla
added
skip visual snapshots
ashetland
reviewed
Apr 22, 2025
Contributor
|
Do we need to update the pr description above? |
Contributor
Author
updated! |
Contributor
Author
|
Ignore the previous 3 commits.. #wrongbranch 😅 |
geospatialem
modified the milestones:
2025-04-29 - Apr Milestone,
2025-05-13 - 3.2.0 May Main Release
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Contributor
Author
|
Fresh PR: #14152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #10050
Summary
Adds new semantic color tokens and updates existing semantic shadow tokens
Acceptance criteria
--calcite-color-shadow-1rgba({core.color.neutral.blk-240}, {core.opacity.4})rgba({core.color.neutral.blk-240}, {core.opacity.12})--calcite-color-shadow-2rgba({core.color.neutral.blk-240}, {core.opacity.8})rgba({core.color.neutral.blk-240}, {core.opacity.12})--calcite-color-shadow-3rgba({core.color.neutral.blk-240}, {core.opacity.10})rgba({core.color.neutral.blk-240}, {core.opacity.16})--calcite-color-shadow-sm"x": "{core.size.default.none}","y": "{core.size.default.6}","blur": "{core.size.default.20}","spread": "{core.size.default.none}","color": "{semantic.color.shadow.3}","type": "dropShadow""x": "{core.size.default.none}","y": "{core.size.default.2}","blur": "{core.size.default.8}","spread": "{core.size.default.none}","color": "{semantic.color.shadow.1}","type": "dropShadow"--calcite-color-shadow-md"x": "{core.size.default.none}","y": "{core.size.default.6}","blur": "{core.size.default.20}","spread": "-{core.size.default.4}","color": "{semantic.color.shadow.3}","type": "dropShadow""x": "{core.size.default.none}","y": "{core.size.default.4}","blur": "{core.size.default.12}","spread": "-{core.size.default.2}","color": "{semantic.color.shadow.2}","type": "dropShadow"